hugetlb_encode.h: fix undefined behaviour (34 << 26)
authorMatthias Goergens <matthias.goergens@gmail.com>
Mon, 5 Sep 2022 03:19:04 +0000 (11:19 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 3 Oct 2022 21:02:55 +0000 (14:02 -0700)
commit710bb68c2e3a24512e2d2bae470960d7488e97b1
tree7a922e8d43a037d5feeebc671212a4285c72c7bb
parentc274cd5c9bf5ded4b3f2a4e99f76223c8f006051
hugetlb_encode.h: fix undefined behaviour (34 << 26)

Left-shifting past the size of your datatype is undefined behaviour in C.
The literal 34 gets the type `int`, and that one is not big enough to be
left shifted by 26 bits.

An `unsigned` is long enough (on any machine that has at least 32 bits for
their ints.)

For uniformity, we mark all the literals as unsigned.  But it's only
really needed for HUGETLB_FLAG_ENCODE_16GB.

Thanks to Randy Dunlap for an initial review and suggestion.

Link: https://lkml.kernel.org/r/20220905031904.150925-1-matthias.goergens@gmail.com
Signed-off-by: Matthias Goergens <matthias.goergens@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/uapi/asm-generic/hugetlb_encode.h
tools/include/asm-generic/hugetlb_encode.h