selinux: fix double free of cond_list on error paths
authorVratislav Bendel <vbendel@redhat.com>
Wed, 2 Feb 2022 11:25:11 +0000 (12:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Feb 2022 17:34:02 +0000 (18:34 +0100)
commit70caa32e6d81f45f0702070c0e4dfe945e92fbd7
tree81eb8c04c1a7832dbc9dec4fb203672c5352e443
parentd63d077fc44645d51df7e9007df87853f5c13e4c
selinux: fix double free of cond_list on error paths

commit 186edf7e368c40d06cf727a1ad14698ea67b74ad upstream.

On error path from cond_read_list() and duplicate_policydb_cond_list()
the cond_list_destroy() gets called a second time in caller functions,
resulting in NULL pointer deref.  Fix this by resetting the
cond_list_len to 0 in cond_list_destroy(), making subsequent calls a
noop.

Also consistently reset the cond_list pointer to NULL after freeing.

Cc: stable@vger.kernel.org
Signed-off-by: Vratislav Bendel <vbendel@redhat.com>
[PM: fix line lengths in the description]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/selinux/ss/conditional.c