xfrm: Fix stack-out-of-bounds read on socket policy lookup.
authorSteffen Klassert <steffen.klassert@secunet.com>
Wed, 29 Nov 2017 05:53:55 +0000 (06:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Feb 2018 10:07:47 +0000 (11:07 +0100)
commit70c5e41f4734ee5cbafb5c49576bdc914f02c6b8
tree4f032f5c1a14779cd329885512b47cac7a7d6b28
parentd6b36a2616ab94040b24ce622bd6befb1a28e4aa
xfrm: Fix stack-out-of-bounds read on socket policy lookup.

commit ddc47e4404b58f03e98345398fb12d38fe291512 upstream.

When we do tunnel or beet mode, we pass saddr and daddr from the
template to xfrm_state_find(), this is ok. On transport mode,
we pass the addresses from the flowi, assuming that the IP
addresses (and address family) don't change during transformation.
This assumption is wrong in the IPv4 mapped IPv6 case, packet
is IPv4 and template is IPv6.

Fix this by catching address family missmatches of the policy
and the flow already before we do the lookup.

Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/xfrm/xfrm_policy.c