AsmParser/Writer: Handle symbolic constants in DI 'flags:'
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 21 Feb 2015 01:02:18 +0000 (01:02 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 21 Feb 2015 01:02:18 +0000 (01:02 +0000)
commit70ab3d2af667a97523d2ab4f03b0d2f978693f47
tree919c0b0fac56a22397ceba0d966be3dd0aec310f
parentc32f3faae9c7128dec280b8274de31400df5e704
AsmParser/Writer: Handle symbolic constants in DI 'flags:'

Parse (and write) symbolic constants in debug info `flags:` fields.
This prevents a readability (and CHECK-ability) regression with the new
debug info hierarchy.

Old (well, current) assembly, with pretty-printing:

    !{!"...\\0016387", ...} ; ... [public] [rvalue reference]

Flags field without this change:

   !MDDerivedType(flags: 16387, ...)

Flags field with this change:

   !MDDerivedType(flags: DIFlagPublic | DIFlagRValueReference, ...)

As discussed in the review thread, this isn't a final state.  Most of
these flags correspond to `DW_AT_` symbolic constants, and we might
eventually want to support arbitrary attributes in some form.  However,
as it stands now, some of the flags correspond to other concepts (like
`FlagStaticMember`); until things are refactored this is the simplest
way to move forward without regressing assembly.

llvm-svn: 230111
llvm/lib/AsmParser/LLLexer.cpp
llvm/lib/AsmParser/LLParser.cpp
llvm/lib/AsmParser/LLToken.h
llvm/lib/IR/AsmWriter.cpp
llvm/test/Assembler/debug-info.ll
llvm/test/Assembler/invalid-mdsubroutinetype-missing-types.ll
llvm/test/Assembler/mdlocalvariable.ll
llvm/test/Assembler/mdsubprogram.ll
llvm/utils/vim/llvm.vim