nvme-tcp: fix possible hang when failing to set io queues
authorSagi Grimberg <sagi@grimberg.me>
Mon, 15 Mar 2021 21:04:26 +0000 (14:04 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Mar 2021 08:04:07 +0000 (09:04 +0100)
commit7089cdfce32f9cf5397350140216bbc000347bae
tree6cd8dbf2b7ffc9917b1c17a0916ce1108354c97f
parenta83e5c6c35fa0ad0259b850e1f727fee922e3ba3
nvme-tcp: fix possible hang when failing to set io queues

commit 72f572428b83d0bc7028e7c4326d1a5f45205e44 upstream.

We only setup io queues for nvme controllers, and it makes absolutely no
sense to allow a controller (re)connect without any I/O queues.  If we
happen to fail setting the queue count for any reason, we should not
allow this to be a successful reconnect as I/O has no chance in going
through. Instead just fail and schedule another reconnect.

Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvme/host/tcp.c