iommu/virtio: Fix freeing of incomplete domains
authorJean-Philippe Brucker <jean-philippe@linaro.org>
Thu, 26 Mar 2020 09:35:57 +0000 (10:35 +0100)
committerJoerg Roedel <jroedel@suse.de>
Fri, 27 Mar 2020 10:09:19 +0000 (11:09 +0100)
commit7062af3ed2ba451029e3733d9f677c68f5ea9e77
tree626fea3935ff83ce8d3ae19d18ef587d7a9ee97c
parent3f84b96c9779c8c2c8f4215a9d08cc6af1d45fdb
iommu/virtio: Fix freeing of incomplete domains

Calling viommu_domain_free() on a domain that hasn't been finalised (not
attached to any device, for example) can currently cause an Oops,
because we attempt to call ida_free() on ID 0, which may either be
unallocated or used by another domain.

Only initialise the vdomain->viommu pointer, which denotes a finalised
domain, at the end of a successful viommu_domain_finalise().

Fixes: edcd69ab9a32 ("iommu: Add virtio-iommu driver")
Reported-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20200326093558.2641019-3-jean-philippe@linaro.org
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/virtio-iommu.c