rust: sync: reduce stack usage of `UniqueArc::try_new_uninit`
authorBenno Lossin <benno.lossin@proton.me>
Sat, 8 Apr 2023 12:26:27 +0000 (12:26 +0000)
committerMiguel Ojeda <ojeda@kernel.org>
Wed, 12 Apr 2023 16:41:05 +0000 (18:41 +0200)
commit701608bd030a888f654862295a49c5d0f42f864c
treeac4f88a1371fca7845390809964512c84f2797b0
parent692e8935e23efab6c5d5fc4b003816b33c8082f7
rust: sync: reduce stack usage of `UniqueArc::try_new_uninit`

`UniqueArc::try_new_uninit` calls `Arc::try_new(MaybeUninit::uninit())`.
This results in the uninitialized memory being placed on the stack,
which may be arbitrarily large due to the generic `T` and thus could
cause a stack overflow for large types.

Change the implementation to use the pin-init API which enables in-place
initialization. In particular it avoids having to first construct and
then move the uninitialized memory from the stack into the final location.

Signed-off-by: Benno Lossin <benno.lossin@proton.me>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com>
Link: https://lore.kernel.org/r/20230408122429.1103522-15-y86-dev@protonmail.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
rust/kernel/lib.rs
rust/kernel/sync/arc.rs