ASoC: qcom: lpass: Fix out-of-bounds DAI ID lookup
authorStephan Gerhold <stephan@gerhold.net>
Mon, 25 Jan 2021 10:44:42 +0000 (11:44 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 25 Jan 2021 12:53:45 +0000 (12:53 +0000)
commit70041000450d0a071bf9931d634c8e2820340236
tree34cc30d0cd30ad8c02bb117cd0ad6d25f2dc2d4c
parent339f6c73d5abe85550a0c962edc8a5df1f2b4273
ASoC: qcom: lpass: Fix out-of-bounds DAI ID lookup

The "dai_id" given into LPAIF_INTFDMA_REG(...) is already the real
DAI ID, not an index into v->dai_driver. Looking it up again seems
entirely redundant.

For IPQ806x (and SC7180 since commit 09a4f6f5d21c
("ASoC: dt-bindings: lpass: Fix and common up lpass dai ids") this is
now often an out-of-bounds read because the indexes in the "dai_driver"
array no longer match the actual DAI ID.

Cc: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Fixes: 7cb37b7bd0d3 ("ASoC: qcom: Add support for lpass hdmi driver")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210125104442.135899-1-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass-lpaif-reg.h