af_packet: do not use READ_ONCE() in packet_bind()
authorEric Dumazet <edumazet@google.com>
Fri, 26 May 2023 15:43:42 +0000 (15:43 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 30 May 2023 05:03:48 +0000 (22:03 -0700)
commit6ffc57ea004234d9373c57b204fd10370a69f392
tree3ee21a4fe73ad89df54c48a290bf1c1699ec7201
parent0684f29a89e58944a9bfae3a8b5c1a217e44c960
af_packet: do not use READ_ONCE() in packet_bind()

A recent patch added READ_ONCE() in packet_bind() and packet_bind_spkt()

This is better handled by reading pkt_sk(sk)->num later
in packet_do_bind() while appropriate lock is held.

READ_ONCE() in writers are often an evidence of something being wrong.

Fixes: 822b5a1c17df ("af_packet: Fix data-races of pkt_sk(sk)->num.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://lore.kernel.org/r/20230526154342.2533026-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/packet/af_packet.c