[SCSI] ipr: fix PCI permanent error handler
authorKleber S. Souza <klebers@linux.vnet.ibm.com>
Mon, 4 May 2009 13:41:02 +0000 (10:41 -0300)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sat, 23 May 2009 20:44:07 +0000 (15:44 -0500)
commit6ff63896e5bd624d8563f4b67fe2fe06ce99c8dc
tree52174e359a0e8e431681cc39a4af81732bf2fc48
parenta3ec723a949d65bf0349cdf60958036454927729
[SCSI] ipr: fix PCI permanent error handler

The ipr driver can hang if it encounters enough PCI errors
to trigger the permanent error handler. The driver will attempt
to initiate a "bringdown" of the adapter and fail all pending
ops back. However, this bringdown is unlike any other bringdown
of the adapter in the code as the driver. In this code path we
end up failing back ops with allow_cmds still set to 1. This results
in some commands, the HCAM commands in particular, getting immediately
re-issued to the adapter on the done call, which results in
an infinite loop in ipr_fail_all_ops. Fix this by setting allow_cmds
to zero in this path.

Signed-off-by: Kleber S. Souza <klebers@linux.vnet.ibm.com>
[brking@linux.vnet.ibm.com: alternate patch substituted]
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/ipr.c