rtc: snvs: fix possible race condition
authorAnson Huang <Anson.Huang@nxp.com>
Tue, 16 Jul 2019 07:18:58 +0000 (15:18 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 29 Aug 2019 15:53:12 +0000 (17:53 +0200)
commit6fd4fe9b496d9ba3382992ff4fde3871d1b6f63d
tree41aa0933b5122855eb9c52d516e0eb362c6497ab
parent28abbba36a5a9f35bfaa75bf8ee0ebf2fe40b9e3
rtc: snvs: fix possible race condition

The RTC IRQ is requested before the struct rtc_device is allocated,
this may lead to a NULL pointer dereference in IRQ handler.

To fix this issue, allocating the rtc_device struct before requesting
the RTC IRQ using devm_rtc_allocate_device, and use rtc_register_device
to register the RTC device.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Link: https://lore.kernel.org/r/20190716071858.36750-1-Anson.Huang@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-snvs.c