netfilter: nfnetlink_log: fix error return code in init path
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 29 Aug 2012 06:49:17 +0000 (06:49 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 30 Aug 2012 01:29:58 +0000 (03:29 +0200)
commit6fc09f10f12477bdaa54e94f9cb428bef6d81315
treea1b57cd35fdf933d44614d70d4ac93196156047a
parentef6acf68c259d907517dcc0ffefcd4e30276ae29
netfilter: nfnetlink_log: fix error return code in init path

Initialize return variable before exiting on an error path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nfnetlink_log.c