USB: serial: fix race in generic write
authorJohan Hovold <jhovold@gmail.com>
Sat, 9 Nov 2013 11:38:09 +0000 (12:38 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Nov 2013 16:39:40 +0000 (08:39 -0800)
commit6f6485463aada1ec6a0f3db6a03eb8e393d6bb55
tree762025100372064a9dd63223fc201d8e79fcebea
parent6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae
USB: serial: fix race in generic write

Fix race in generic write implementation, which could lead to
temporarily degraded throughput.

The current generic write implementation introduced by commit
27c7acf22047 ("USB: serial: reimplement generic fifo-based writes") has
always had this bug, although it's fairly hard to trigger and the
consequences are not likely to be noticed.

Specifically, a write() on one CPU while the completion handler is
running on another could result in only one of the two write urbs being
utilised to empty the remainder of the write fifo (unless there is a
second write() that doesn't race during that time).

Cc: stable <stable@vger.kernel.org> # 2.6.35
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/generic.c