md: add a mutex to synchronize idle and frozen in action_store()
authorYu Kuai <yukuai3@huawei.com>
Mon, 29 May 2023 13:20:34 +0000 (21:20 +0800)
committerSong Liu <song@kernel.org>
Thu, 27 Jul 2023 07:13:28 +0000 (00:13 -0700)
commit6f56f0c4f1241f1694a6a9438dd4f78d4513a917
tree3b41e3b51cf8e5c1c21a056103722137c6e367e8
parent64e5e09afc14f8cc9058b0ed5c9cc4c8cd126b85
md: add a mutex to synchronize idle and frozen in action_store()

Currently, for idle and frozen, action_store will hold 'reconfig_mutex'
and call md_reap_sync_thread() to stop sync thread, however, this will
cause deadlock (explained in the next patch). In order to fix the
problem, following patch will release 'reconfig_mutex' and wait on
'resync_wait', like md_set_readonly() and do_md_stop() does.

Consider that action_store() will set/clear 'MD_RECOVERY_FROZEN'
unconditionally, which might cause unexpected problems, for example,
frozen just set 'MD_RECOVERY_FROZEN' and is still in progress, while
'idle' clear 'MD_RECOVERY_FROZEN' and new sync thread is started, which
might starve in progress frozen. A mutex is added to synchronize idle
and frozen from action_store().

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230529132037.2124527-4-yukuai1@huaweicloud.com
drivers/md/md.c
drivers/md/md.h