leds: da903x: fix use-after-free on unbind
authorJohan Hovold <johan@kernel.org>
Mon, 1 Jun 2020 13:39:46 +0000 (15:39 +0200)
committerPavel Machek <pavel@ucw.cz>
Mon, 22 Jun 2020 08:37:58 +0000 (10:37 +0200)
commit6f4aa35744f69ed9b0bf5a736c9ca9b44bc1dcea
tree569f7401e7e0fadd56bf2658fd61f6b79cf067e2
parenteca21c2d8655387823d695b26e6fe78cf3975c05
leds: da903x: fix use-after-free on unbind

Several MFD child drivers register their class devices directly under
the parent device. This means you cannot blindly do devres conversions
so that deregistration ends up being tied to the parent device,
something which leads to use-after-free on driver unbind when the class
device is released while still being registered.

Fixes: eed16255d66b ("leds: da903x: Use devm_led_classdev_register")
Cc: stable <stable@vger.kernel.org> # 4.6
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-da903x.c