spi: qup: hide warning for uninitialized variable
authorArnd Bergmann <arnd@arndb.de>
Thu, 10 Aug 2017 12:13:26 +0000 (14:13 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 10 Aug 2017 14:50:17 +0000 (15:50 +0100)
commit6f38f125ffc4d87768129644fb485eca7382f0b1
tree7b1ebb71fbb65000a4001d21184aa190f0dfc3de
parent4d023737b2efcaac36e4e6bbfdce3a3b377f3946
spi: qup: hide warning for uninitialized variable

The added conditionals in this function apparently confused
gcc to the point that it no longer sees the code is safe and
instead shows a false-positive warning:

drivers/spi/spi-qup.c: In function 'spi_qup_transfer_one':
drivers/spi/spi-qup.c:507:28: error: 'tx_nents' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/spi/spi-qup.c:464:17: note: 'tx_nents' was declared here
drivers/spi/spi-qup.c:505:28: error: 'rx_nents' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/spi/spi-qup.c:464:7: note: 'rx_nents' was declared here

This moves the initialization to a place that makes it obvious
to the compiler.

Fixes: 5884e17ef3cb ("spi: qup: allow multiple DMA transactions per spi xfer")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qup.c