Explain why the array bound is non-constant in VLA diagnostics.
authorRichard Smith <richard@metafoo.co.uk>
Wed, 19 Aug 2020 19:46:22 +0000 (12:46 -0700)
committerRichard Smith <richard@metafoo.co.uk>
Wed, 19 Aug 2020 22:45:51 +0000 (15:45 -0700)
commit6f339367195e7464df87571062529bbe20157bdf
tree98998b5e88e9fb578bf6ffa78f2d429acc041603
parent09ca3f41bbc5c2c4480accd6404f61bd9e5172a5
Explain why the array bound is non-constant in VLA diagnostics.

In passing, also use a more precise diagnostic to explain why an
expression is not an ICE if it's not of integral type.
121 files changed:
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaDeclCXX.cpp
clang/lib/Sema/SemaExpr.cpp
clang/lib/Sema/SemaTemplate.cpp
clang/lib/Sema/SemaType.cpp
clang/test/CXX/drs/dr0xx.cpp
clang/test/CXX/drs/dr3xx.cpp
clang/test/CXX/drs/dr4xx.cpp
clang/test/CXX/expr/expr.const/p2-0x.cpp
clang/test/CXX/expr/expr.const/p5-0x.cpp
clang/test/OpenMP/atomic_messages.c
clang/test/OpenMP/critical_messages.cpp
clang/test/OpenMP/declare_simd_messages.cpp
clang/test/OpenMP/distribute_collapse_messages.cpp
clang/test/OpenMP/distribute_parallel_for_collapse_messages.cpp
clang/test/OpenMP/distribute_parallel_for_simd_aligned_messages.cpp
clang/test/OpenMP/distribute_parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/distribute_parallel_for_simd_misc_messages.c
clang/test/OpenMP/distribute_parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/distribute_parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/distribute_simd_aligned_messages.cpp
clang/test/OpenMP/distribute_simd_collapse_messages.cpp
clang/test/OpenMP/distribute_simd_misc_messages.c
clang/test/OpenMP/distribute_simd_safelen_messages.cpp
clang/test/OpenMP/distribute_simd_simdlen_messages.cpp
clang/test/OpenMP/for_collapse_messages.cpp
clang/test/OpenMP/for_misc_messages.c
clang/test/OpenMP/for_ordered_clause.cpp
clang/test/OpenMP/for_simd_aligned_messages.cpp
clang/test/OpenMP/for_simd_collapse_messages.cpp
clang/test/OpenMP/for_simd_misc_messages.c
clang/test/OpenMP/for_simd_safelen_messages.cpp
clang/test/OpenMP/for_simd_simdlen_messages.cpp
clang/test/OpenMP/master_taskloop_collapse_messages.cpp
clang/test/OpenMP/master_taskloop_misc_messages.c
clang/test/OpenMP/master_taskloop_simd_aligned_messages.cpp
clang/test/OpenMP/master_taskloop_simd_collapse_messages.cpp
clang/test/OpenMP/master_taskloop_simd_misc_messages.c
clang/test/OpenMP/master_taskloop_simd_safelen_messages.cpp
clang/test/OpenMP/master_taskloop_simd_simdlen_messages.cpp
clang/test/OpenMP/ordered_messages.cpp
clang/test/OpenMP/parallel_for_collapse_messages.cpp
clang/test/OpenMP/parallel_for_misc_messages.c
clang/test/OpenMP/parallel_for_ordered_messages.cpp
clang/test/OpenMP/parallel_for_simd_aligned_messages.cpp
clang/test/OpenMP/parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/parallel_for_simd_misc_messages.c
clang/test/OpenMP/parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/parallel_master_taskloop_collapse_messages.cpp
clang/test/OpenMP/parallel_master_taskloop_misc_messages.c
clang/test/OpenMP/parallel_master_taskloop_simd_aligned_messages.cpp
clang/test/OpenMP/parallel_master_taskloop_simd_collapse_messages.cpp
clang/test/OpenMP/parallel_master_taskloop_simd_misc_messages.c
clang/test/OpenMP/parallel_master_taskloop_simd_safelen_messages.cpp
clang/test/OpenMP/parallel_master_taskloop_simd_simdlen_messages.cpp
clang/test/OpenMP/simd_aligned_messages.cpp
clang/test/OpenMP/simd_collapse_messages.cpp
clang/test/OpenMP/simd_misc_messages.c
clang/test/OpenMP/simd_safelen_messages.cpp
clang/test/OpenMP/simd_simdlen_messages.cpp
clang/test/OpenMP/target_parallel_for_collapse_messages.cpp
clang/test/OpenMP/target_parallel_for_misc_messages.c
clang/test/OpenMP/target_parallel_for_ordered_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_aligned_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_misc_messages.c
clang/test/OpenMP/target_parallel_for_simd_ordered_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/target_simd_aligned_messages.cpp
clang/test/OpenMP/target_simd_collapse_messages.cpp
clang/test/OpenMP/target_simd_misc_messages.c
clang/test/OpenMP/target_simd_safelen_messages.cpp
clang/test/OpenMP/target_simd_simdlen_messages.cpp
clang/test/OpenMP/target_teams_distribute_collapse_messages.cpp
clang/test/OpenMP/target_teams_distribute_misc_messages.c
clang/test/OpenMP/target_teams_distribute_parallel_for_collapse_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_misc_messages.c
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_aligned_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_misc_messages.c
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/target_teams_distribute_simd_aligned_messages.cpp
clang/test/OpenMP/target_teams_distribute_simd_collapse_messages.cpp
clang/test/OpenMP/target_teams_distribute_simd_misc_messages.c
clang/test/OpenMP/target_teams_distribute_simd_safelen_messages.cpp
clang/test/OpenMP/target_teams_distribute_simd_simdlen_messages.cpp
clang/test/OpenMP/taskloop_collapse_messages.cpp
clang/test/OpenMP/taskloop_misc_messages.c
clang/test/OpenMP/taskloop_simd_aligned_messages.cpp
clang/test/OpenMP/taskloop_simd_collapse_messages.cpp
clang/test/OpenMP/taskloop_simd_misc_messages.c
clang/test/OpenMP/taskloop_simd_safelen_messages.cpp
clang/test/OpenMP/taskloop_simd_simdlen_messages.cpp
clang/test/OpenMP/teams_distribute_collapse_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_collapse_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_simd_aligned_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/teams_distribute_simd_aligned_messages.cpp
clang/test/OpenMP/teams_distribute_simd_collapse_messages.cpp
clang/test/OpenMP/teams_distribute_simd_safelen_messages.cpp
clang/test/OpenMP/teams_distribute_simd_simdlen_messages.cpp
clang/test/PCH/cxx-constexpr.cpp
clang/test/Sema/bitfield.c
clang/test/Sema/c89.c
clang/test/Sema/complex-int.c
clang/test/Sema/warn-vla.c
clang/test/SemaCXX/c99-variable-length-array-cxx11.cpp
clang/test/SemaCXX/c99-variable-length-array.cpp
clang/test/SemaCXX/constant-expression-cxx11.cpp
clang/test/SemaCXX/constant-expression.cpp
clang/test/SemaCXX/vla-construct.cpp [moved from clang/test/SemaCXX/vla-consruct.cpp with 85% similarity]
clang/test/SemaCXX/warn-vla.cpp
clang/test/SemaObjC/class-bitfield.m
clang/test/SemaTemplate/instantiate-self.cpp