Add some checks for merged test groups (#89521)
authorMark Plesko <markples@microsoft.com>
Fri, 28 Jul 2023 18:39:19 +0000 (11:39 -0700)
committerGitHub <noreply@github.com>
Fri, 28 Jul 2023 18:39:19 +0000 (11:39 -0700)
commit6f27090e059de06b50516a6485576943876d6914
tree162c1d3cd67be598b9fb2f7f6379d47b98704bab
parent91ba52cfc867e89f6fe78ffee329699829ec4ecf
Add some checks for merged test groups (#89521)

- CLRTest.Execute.Batch.targets
  - Fix CLRTestExecutionArguments (allows passing a filter argument to <mergedgroup>.cmd
  - Fix indenting in generated script
- XUnitWrapperGenerator
  - Move some generated code into (shared) ITestInfo.cs
  - Also display exception on stdout on failure
  - Add check that projects in merged test groups don't contain entry points
    - Can be a sign of code that is expected to run but won't be
    - Or can be a [Fact]/etc-less entry point in a ReqProcIso project but would then need to be fixed if ReqProcIso were removed
- Directory.Build.targets
  - Run XUnitWrapperGenerator on test projects in merged groups
  - Can't simply replace the conditional because we have XUnit-style tests outside of merged groups
- Update tests to conform to above checks plus a bit of opportunistic cleanup
22 files changed:
src/tests/Common/CLRTest.Execute.Batch.targets
src/tests/Common/XUnitWrapperGenerator/Descriptors.cs [new file with mode: 0644]
src/tests/Common/XUnitWrapperGenerator/ITestInfo.cs
src/tests/Common/XUnitWrapperGenerator/OptionsHelper.cs
src/tests/Common/XUnitWrapperGenerator/RoslynUtils.cs [new file with mode: 0644]
src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.props
src/tests/Common/XUnitWrapperLibrary/TestSummary.cs
src/tests/Directory.Build.targets
src/tests/JIT/Methodical/delegate/GSDelegate.cs
src/tests/JIT/Methodical/delegate/GSDelegate.csproj
src/tests/JIT/Methodical/delegate/VirtualDelegate.cs
src/tests/JIT/Methodical/delegate/VirtualDelegate.csproj
src/tests/JIT/Regression/CLR-x86-JIT/V1.2-M01/b08046cs/SyncGCHole.cs
src/tests/JIT/Regression/CLR-x86-JIT/V1.2-M01/b08046cs/b08046cs.csproj
src/tests/JIT/Regression/JitBlue/Runtime_75832/Runtime_75832.cs
src/tests/JIT/Regression/JitBlue/Runtime_82535/Runtime_82535.cs
src/tests/JIT/Regression/JitBlue/Runtime_82535/Runtime_82535.csproj
src/tests/JIT/jit64/hfa/main/dll/hfa_nested_f64_interop_cpp.csproj
src/tests/JIT/opt/Devirtualization/box2.cs
src/tests/JIT/opt/Devirtualization/box2.csproj
src/tests/issues.targets