Add support for v3 binary annotation notes.
authorNick Clifton <nickc@redhat.com>
Wed, 3 Jan 2018 10:28:33 +0000 (10:28 +0000)
committerNick Clifton <nickc@redhat.com>
Wed, 3 Jan 2018 10:30:07 +0000 (10:30 +0000)
commit6f156d7a4ad1c245b357dc50f63f3564d397839e
treea247aad883eb6ba6eeb0c9715c218527fc25c869
parent9f757bf7fcb8834ead780e0c4a76d6029b1402c2
Add support for v3 binary annotation notes.

  I am checking in the attached patch which updates the binutils
  support for version 3 binary annotation notes.  (Version 3 adds
  an end address to the ranges covered by the notes, so that it
  is possible to detect gaps in the coverage).

  This patch also stops the note merging feature of objcopy from
  executing if the notes have relocations against them.  This makes the
  code simpler, and prevents the problems with architectures which have
  unusual relocation management issues.

* objcopy.c (objcopy_internal_note): New structure.
(gap_exists): New function.
(is_open_note): New function.
(is_func_note): New function.
(is_64bit): New function.
(merge_gnu_build_notes): Handle v3 notes.  Do not merge
if there are relocations against the notes.
* readelf.c (get_note_type): Use short names for build attribute
notes.
(print_symbol_for_build_attribute): Rename to
get_symbol_for_build_attribute.  Returns the found symbol rather
than printing it.
(print_gnu_build_attribute_description): Maintain address ranges
for function notes as well as global notes.  Handle v3 notes.
(print_gnu_build_attribute_name): Use more space for printing the
name in wide mode.
* testsuite/binutils-all/note-2-32.s: Use .dc.l instead of .word.
Eliminate symbol references in order to remove the need for
relocations.
* testsuite/binutils-all/note-2-64.s: Likewise.
* testsuite/binutils-all/note-3-32.s: Add a size to the note_1
symbol.
* testsuite/binutils-all/note-3-64.s: Likewise.
* testsuite/binutils-all/mips/mips-note-2r-n32.d: Update expected
output.
* testsuite/binutils-all/mips/mips-note-2r-n64.d: Likewise.
* testsuite/binutils-all/mips/mips-note-2r.d: Likewise.
* testsuite/binutils-all/note-2-32.d: Likewise.
* testsuite/binutils-all/note-2-64.d: Likewise.
* testsuite/binutils-all/note-3-32.d: Likewise.
* testsuite/binutils-all/note-3-64.d: Likewise.
* testsuite/binutils-all/note-4-64.s: New test.  Checks v3 notes.
* testsuite/binutils-all/note-4-32.s: New test.
* testsuite/binutils-all/note-4-64.d: New test result file.
* testsuite/binutils-all/note-4-32.d: New test result file.
19 files changed:
binutils/ChangeLog
binutils/objcopy.c
binutils/readelf.c
binutils/testsuite/binutils-all/mips/mips-note-2r-n32.d
binutils/testsuite/binutils-all/mips/mips-note-2r-n64.d
binutils/testsuite/binutils-all/mips/mips-note-2r.d
binutils/testsuite/binutils-all/note-2-32.d
binutils/testsuite/binutils-all/note-2-32.s
binutils/testsuite/binutils-all/note-2-64.d
binutils/testsuite/binutils-all/note-2-64.s
binutils/testsuite/binutils-all/note-3-32.d
binutils/testsuite/binutils-all/note-3-32.s
binutils/testsuite/binutils-all/note-3-64.d
binutils/testsuite/binutils-all/note-3-64.s
binutils/testsuite/binutils-all/note-4-32.d [new file with mode: 0644]
binutils/testsuite/binutils-all/note-4-32.s [new file with mode: 0644]
binutils/testsuite/binutils-all/note-4-64.d [new file with mode: 0644]
binutils/testsuite/binutils-all/note-4-64.s [new file with mode: 0644]
binutils/testsuite/binutils-all/objcopy.exp