[IndVars] Try to use existing values in RewriteLoopExitValues.
authorSanjoy Das <sanjoy@playingwithpointers.com>
Thu, 9 Jul 2015 18:46:12 +0000 (18:46 +0000)
committerSanjoy Das <sanjoy@playingwithpointers.com>
Thu, 9 Jul 2015 18:46:12 +0000 (18:46 +0000)
commit6f062c8c2a3de7140341dbe03af80ae840c91492
treee143c871b302e9fc25d37b3db094576f09ee5773
parent1bd3c9abd8984544380f3ea48d343790dcee0263
[IndVars] Try to use existing values in RewriteLoopExitValues.

Summary:
In RewriteLoopExitValues, before expanding out an SCEV expression using
SCEVExpander, try to see if an existing LLVM IR expression already
computes the value we're interested in.  If so use that existing
expression.

Apart from reducing IndVars' reliance on the rest of the compilation
pipeline, this also prevents IndVars from concluding some expressions as
"high cost" when they're not.  For instance,
`InductiveRangeCheckElimination` often emits code of the following form:

```
len = umin(len_A, len_B)

loop:
  ...
  if (i++ < len)
    goto loop

outside_loop:
    use(i)
```

`SCEVExpander` refuses to rewrite the use of `i` in `outside_loop`,
since it thinks the value of `i` on loop exit, `len`, is a high cost
expansion since it contains an `umax` in it.  With this change,
`IndVars` can see that it can re-use `len` instead of creating a new
expression to compute `umin(len_A, len_B)`.

I considered putting this cleverness in `SCEVExpander`, but I was
worried that it may then have a deterimental effect on other passes
that use it.  So I decided it was better to just do this in the one
place where it seems like an obviously good idea, with the intent of
generalizing later if needed.

Reviewers: atrick, reames

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D10782

llvm-svn: 241838
llvm/lib/Transforms/Scalar/IndVarSimplify.cpp
llvm/test/Transforms/IndVarSimplify/lrev-existing-umin.ll [new file with mode: 0644]