netfilter: conntrack: Avoid nf_ct_helper_hash uses after free
authorFlorent Revest <revest@chromium.org>
Mon, 3 Jul 2023 14:52:16 +0000 (16:52 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 5 Jul 2023 12:42:15 +0000 (14:42 +0200)
commit6eef7a2b933885a17679eb8ed0796ddf0ee5309b
tree61f894d8e56fec0a17341c8605cc36041a884757
parent8a9dc07ba92497a81f1ff65d25c2ba7b6f9a8bdc
netfilter: conntrack: Avoid nf_ct_helper_hash uses after free

If nf_conntrack_init_start() fails (for example due to a
register_nf_conntrack_bpf() failure), the nf_conntrack_helper_fini()
clean-up path frees the nf_ct_helper_hash map.

When built with NF_CONNTRACK=y, further netfilter modules (e.g:
netfilter_conntrack_ftp) can still be loaded and call
nf_conntrack_helpers_register(), independently of whether nf_conntrack
initialized correctly. This accesses the nf_ct_helper_hash dangling
pointer and causes a uaf, possibly leading to random memory corruption.

This patch guards nf_conntrack_helper_register() from accessing a freed
or uninitialized nf_ct_helper_hash pointer and fixes possible
uses-after-free when loading a conntrack module.

Cc: stable@vger.kernel.org
Fixes: 12f7a505331e ("netfilter: add user-space connection tracking helper infrastructure")
Signed-off-by: Florent Revest <revest@chromium.org>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_helper.c