net/x25: prevent a couple of overflows
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 1 Dec 2020 15:15:12 +0000 (18:15 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Dec 2020 01:26:36 +0000 (17:26 -0800)
commit6ee50c8e262a0f0693dad264c3c99e30e6442a56
treef4c7d9a7f7cf6314c4bce4ba346cd5f91ff95000
parent07500a6085806d97039ebcba8d9b8b29129f0106
net/x25: prevent a couple of overflows

The .x25_addr[] address comes from the user and is not necessarily
NUL terminated.  This leads to a couple problems.  The first problem is
that the strlen() in x25_bind() can read beyond the end of the buffer.

The second problem is more subtle and could result in memory corruption.
The call tree is:
  x25_connect()
  --> x25_write_internal()
      --> x25_addr_aton()

The .x25_addr[] buffers are copied to the "addresses" buffer from
x25_write_internal() so it will lead to stack corruption.

Verify that the strings are NUL terminated and return -EINVAL if they
are not.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Fixes: a9288525d2ae ("X25: Dont let x25_bind use addresses containing characters")
Reported-by: "kiyin(尹亮)" <kiyin@tencent.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Martin Schiller <ms@dev.tdt.de>
Link: https://lore.kernel.org/r/X8ZeAKm8FnFpN//B@mwanda
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/x25/af_x25.c