io_uring: remove io_free_req_tw
authorPavel Begunkov <asml.silence@gmail.com>
Fri, 23 Jun 2023 11:23:22 +0000 (12:23 +0100)
committerJens Axboe <axboe@kernel.dk>
Fri, 23 Jun 2023 14:19:39 +0000 (08:19 -0600)
commit6ec9afc7f4cba58ab740c59d4c964d9422e2ea82
tree87085dba716a84065b038739d9765520a0c5dba5
parent247f97a5f19b642eba5f5c1cf95fc3169326b3fb
io_uring: remove io_free_req_tw

Request completion is a very hot path in general, but there are 3 places
that can be doing it: io_free_batch_list(), io_req_complete_post() and
io_free_req_tw().

io_free_req_tw() is used rather marginally and we don't care about it.
Killing it can help to clean up and optimise the left two, do that by
replacing it with io_req_task_complete().

There are two things to consider:
1) io_free_req() is called when all refs are put, so we need to reinit
   references. The easiest way to do that is to clear REQ_F_REFCOUNT.
2) We also don't need a cqe from it, so silence it with REQ_F_CQE_SKIP.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/434a2be8f33d474ad888ce1c17fe5ea7bbcb2a55.1687518903.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/io_uring.c