ecore_con: send server_upgrade event *after* clearing pending saves
authorBryce Harrington <bryce@osg.samsung.com>
Wed, 12 Apr 2017 21:38:56 +0000 (14:38 -0700)
committerCedric BAIL <cedric@osg.samsung.com>
Wed, 12 Apr 2017 21:39:08 +0000 (14:39 -0700)
commit6ea18851ba9f345f3fc49a7c154048f2832cdfe9
tree6479ebe93bd995d4cf77ce62f6b0b2a2dc43c505
parentbb1a8779dbff0aa059f482c89104ff4f07556508
ecore_con: send server_upgrade event *after* clearing pending saves

Summary:
The _ecore_con_post_event_server_upgrade() call adds an event to free
the server_upgrade object, svr, via  _ecore_con_server_free(svr) so we
should assume srv is freed after it returns.  Thus, perform the
pending_slice processing prior to calling it.  Otherwise it triggers an
illegal access (USE_AFTER_FREE) error in Coverity.

@fix CID1373485

Reviewers: barbieri

Reviewed By: barbieri

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4785

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
src/lib/ecore_con/ecore_con_legacy.c