projects / platform / kernel / linux-rpi.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d6da838) | patch
hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close
authorJia-Ju Bai <baijiaju1990@163.com>
Tue, 12 Dec 2017 08:49:52 +0000 (16:49 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Dec 2017 19:52:57 +0000 (14:52 -0500)
commit6e266610eb6553cfb7e7eb5d11914bd01509c406
tree63f92663cda1108f32af035052ddd56c8f3c847btree | snapshot
parentd6da83813fb39206c73cfb98798cc3c770e5b0a0commit | diff
hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close

The driver may sleep under a spinlock.
The function call path is:
rr_close (acquire the spinlock)
  free_irq --> may sleep

To fix it, free_irq is moved to the place without holding the spinlock.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hippi/rrunner.c diff | blob | history
Domain: System / Kernel;