perf symbols: dso->name is an array, no need to check it against NULL 88/292588/1
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 13 Feb 2017 20:11:03 +0000 (17:11 -0300)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Tue, 9 May 2023 09:23:44 +0000 (18:23 +0900)
commit6e24623612b81d8f14dbd34a616408b9c54b35f0
tree40a3d96b3a7c47efde9866fdb0688e5d39e9805f
parent0c07c6401f23e8c718a36ac0f11e6bffe4f5a3c4
perf symbols: dso->name is an array, no need to check it against NULL

As it will always evaluate to 'true', as reported by clang:

  util/map.c:390:36: error: address of array 'map->dso->name' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
          if (map && map->dso && (map->dso->name || map->dso->long_name)) {
                                  ~~~~~~~~~~^~~~ ~~
  util/map.c:393:22: error: address of array 'map->dso->name' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                  else if (map->dso->name)
                     ~~  ~~~~~~~~~~^~~~

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-x8cu007cly40kfp8xnpi9kya@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
[sw0312.kim: backport upstream commit 5eae7d842510 to resolve gcc-12 build issue]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: I475ce43b3563aac9846e47444ba1d029bd43659a
tools/perf/util/map.c
tools/perf/util/scripting-engines/trace-event-perl.c