rtlwifi: rtl8188ee: avoid accessing the data mapped to streaming DMA
authorJia-Ju Bai <baijiaju1990@gmail.com>
Thu, 19 Nov 2020 01:51:27 +0000 (09:51 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 24 Nov 2020 15:06:34 +0000 (17:06 +0200)
commit6df3c293d284655c72c1a72356ce4d32217a9c54
treea1385980901f9a21769761486ef4afe369d3ae80
parent00331758137245fd3478404ee81de40dfcb3b7de
rtlwifi: rtl8188ee: avoid accessing the data mapped to streaming DMA

In rtl88ee_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on
line 677:
  dma_addr_t mapping = dma_map_single(..., skb->data, ...);

On line 680, skb->data is assigned to hdr after cast:
  struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data);

Then hdr->frame_control is accessed on line 681:
  __le16 fc = hdr->frame_control;

This DMA access may cause data inconsistency between CPU and hardwre.

To fix this bug, hdr->frame_control is accessed before the DMA mapping.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201119015127.12033-1-baijiaju1990@gmail.com
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c