RAS/CEC: Fix pfn insertion
authorBorislav Petkov <bp@suse.de>
Sat, 20 Apr 2019 10:53:05 +0000 (12:53 +0200)
committerBorislav Petkov <bp@suse.de>
Sat, 8 Jun 2019 15:32:00 +0000 (17:32 +0200)
commit6d8e294bf5f0e85c34e8b14b064e2965f53f38b0
tree11867f8240f9cad95ff4b37a4d7758104c79da1b
parent0ade0b6240c4853cf9725924c46c10f4251639d7
RAS/CEC: Fix pfn insertion

When inserting random PFNs for debugging the CEC through
(debugfs)/ras/cec/pfn, depending on the return value of pfn_set(),
multiple values get inserted per a single write.

That is because simple_attr_write() interprets a retval of 0 as
success and claims the whole input. However, pfn_set() returns the
cec_add_elem() value, which, if > 0 and smaller than the whole input
length, makes glibc continue issuing the write syscall until there's
input left:

  pfn_set
  simple_attr_write
  debugfs_attr_write
  full_proxy_write
  vfs_write
  ksys_write
  do_syscall_64
  entry_SYSCALL_64_after_hwframe

leading to those repeated calls.

Return 0 to fix that.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
drivers/ras/cec.c