[clangd] Disable delayed template parsing in the main file
authorSam McCall <sam.mccall@gmail.com>
Sat, 25 Apr 2020 01:03:01 +0000 (03:03 +0200)
committerSam McCall <sam.mccall@gmail.com>
Sun, 26 Apr 2020 12:29:38 +0000 (14:29 +0200)
commit6d7637dc460a3602d725eca8698fa0ecd920031b
tree480efd79de548b8e5a8d1a50f2b860379a739ffe
parent7d57d22baa1125587c45004212651273c9c6f956
[clangd] Disable delayed template parsing in the main file

Summary:
This is on by default in windows and breaks most features in template bodies.
We'd already disabled it in code completion, now disable it for building ASTs.

Potential regressions:
 - we may give spurious errors where files with templates relying on delayed
   parsing are directly opened
 - we may misparse such template bodies that are instantiated (and therefore
   *were* previously parsed)

Still *probably* a win overall. Avoiding the regressions entirely would be
substantial work and we don't have plans for it now.

Fixes https://github.com/clangd/clangd/issues/302 (again)

Reviewers: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78848
clang-tools-extra/clangd/ParsedAST.cpp
clang-tools-extra/clangd/unittests/ParsedASTTests.cpp