vmxnet3: set carrier state properly on probe
authorNeil Horman <nhorman@tuxdriver.com>
Tue, 29 Jan 2013 21:15:45 +0000 (16:15 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Jan 2013 21:29:22 +0000 (16:29 -0500)
commit6cdd20c380eb62eab757c5a6ccc90dac7ecd774b
tree547763439b122d5917fff7aae936b6a1bbcd0d0a
parent286003048aaef49b26bb9d93611dc69085e8982e
vmxnet3: set carrier state properly on probe

vmxnet3 fails to set netif_carrier_off on probe, meaning that when an interface
is opened the __LINK_STATE_NOCARRIER bit is already cleared, and so
/sys/class/net/<ifname>/operstate remains in the unknown state.  Correct this by
setting netif_carrier_off on probe, like other drivers do.

Also, while we're at it, lets remove the netif_carrier_ok checks from the
link_state_update function, as that check is atomically contained within the
netif_carrier_[on|off] functions anyway

Tested successfully by myself

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: "VMware, Inc." <pv-drivers@vmware.com>
CC: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vmxnet3/vmxnet3_drv.c