mm/memory-failure: fix hardware poison check in unpoison_memory()
authorSidhartha Kumar <sidhartha.kumar@oracle.com>
Mon, 17 Jul 2023 18:18:12 +0000 (11:18 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 27 Jul 2023 20:07:05 +0000 (13:07 -0700)
commit6c54312f9689fbe27c70db5d42eebd29d04b672e
tree8cd097ee6e76100260edc1f07e7b4963f7601f89
parent641db40f3afe7998011bfabc726dba3e698f8196
mm/memory-failure: fix hardware poison check in unpoison_memory()

It was pointed out[1] that using folio_test_hwpoison() is wrong as we need
to check the indiviual page that has poison.  folio_test_hwpoison() only
checks the head page so go back to using PageHWPoison().

User-visible effects include existing hwpoison-inject tests possibly
failing as unpoisoning a single subpage could lead to unpoisoning an
entire folio.  Memory unpoisoning could also not work as expected as
the function will break early due to only checking the head page and
not the actually poisoned subpage.

[1]: https://lore.kernel.org/lkml/ZLIbZygG7LqSI9xe@casper.infradead.org/

Link: https://lkml.kernel.org/r/20230717181812.167757-1-sidhartha.kumar@oracle.com
Fixes: a6fddef49eef ("mm/memory-failure: convert unpoison_memory() to folios")
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Reported-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/memory-failure.c