clk: bcm2835: Make peripheral PLLC critical
authorMaxime Ripard <maxime@cerno.tech>
Mon, 26 Sep 2022 08:45:09 +0000 (10:45 +0200)
committerStephen Boyd <sboyd@kernel.org>
Fri, 30 Sep 2022 21:28:18 +0000 (14:28 -0700)
commit6c5422851d8be8c7451e968fd2e6da41b6109e17
treed22947dcc2235dce7cf3399e13baacfb0c293703
parent568035b01cfb107af8d2e4bd2fb9aea22cf5b868
clk: bcm2835: Make peripheral PLLC critical

When testing for a series affecting the VEC, it was discovered that
turning off and on the VEC clock is crashing the system.

It turns out that, when disabling the VEC clock, it's the only child of
the PLLC-per clock which will also get disabled. The source of the crash
is PLLC-per being disabled.

It's likely that some other device might not take a clock reference that
it actually needs, but it's unclear which at this point. Let's make
PLLC-per critical so that we don't have that crash.

Reported-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220926084509.12233-1-maxime@cerno.tech
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/bcm/clk-bcm2835.c