hwtracing: hisi_ptt: Fix potential sleep in atomic context
authorYicong Yang <yangyicong@hisilicon.com>
Wed, 21 Jun 2023 09:28:04 +0000 (17:28 +0800)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Wed, 21 Jun 2023 10:52:39 +0000 (11:52 +0100)
commit6c50384ef8b94a527445e3694ae6549e1f15d859
tree81afd8e02ddbee9736d8fb35f322d654f81d497e
parent45c90292ad0e275ef4b870838b3b5273b3ef8ade
hwtracing: hisi_ptt: Fix potential sleep in atomic context

We're using pci_irq_vector() to obtain the interrupt number and then
bind it to the CPU start perf under the protection of spinlock in
pmu::start(). pci_irq_vector() might sleep since [1] because it will
call msi_domain_get_virq() to get the MSI interrupt number and it
needs to acquire dev->msi.data->mutex. Getting a mutex will sleep on
contention. So use pci_irq_vector() in an atomic context is problematic.

This patch cached the interrupt number in the probe() and uses the
cached data instead to avoid potential sleep.

[1] commit 82ff8e6b78fc ("PCI/MSI: Use msi_get_virq() in pci_get_vector()")

Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230621092804.15120-6-yangyicong@huawei.com
drivers/hwtracing/ptt/hisi_ptt.c
drivers/hwtracing/ptt/hisi_ptt.h