Remove code duplication from RegisterContextPOSIX_*
authorMuhammad Omair Javaid <omair.javaid@linaro.org>
Wed, 17 Jun 2020 19:59:27 +0000 (00:59 +0500)
committerMuhammad Omair Javaid <omair.javaid@linaro.org>
Wed, 17 Jun 2020 20:02:46 +0000 (01:02 +0500)
commit6c45532908bacc0cf569bcad74f6e04e1e2a6c61
treed2625f76f494f51f8a1830ada3c35929239c16ec
parent9d8d0646d751326e2766caeaa20f6e0d4b89a4f6
Remove code duplication from RegisterContextPOSIX_*

Summary:
This patch aims to remove multiple copies of GetByteOrder() and ConvertRegisterKindToRegisterNumber used in various versions of RegisterContextPOSIX_*.

Both register implementations are move to RegisterContext class which is parent of RegisterContextPOSIX_* classes.

Built and tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-linux-gnueabihf targets.

Reviewers: labath

Reviewed By: labath

Subscribers: wuzish, nemanjai, kristof.beyls, kbarton, atanasyan, lldb-commits

Differential Revision: https://reviews.llvm.org/D80104
16 files changed:
lldb/include/lldb/Target/RegisterContext.h
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm.h
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.h
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.h
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.h
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.h
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.h
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.h
lldb/source/Target/RegisterContext.cpp