ACPI: make remove callback of ACPI driver void
authorDawei Li <set_pte_at@outlook.com>
Sun, 13 Nov 2022 16:26:09 +0000 (00:26 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 23 Nov 2022 18:11:22 +0000 (19:11 +0100)
commit6c0eb5ba3500f6da367351ff3c4452c029cb72fa
tree86103c591d5e81a20ffb8d651d8676f81390f21f
parentd7d4332155efe82a3d70ab179dde30cad3b094a4
ACPI: make remove callback of ACPI driver void

For bus-based driver, device removal is implemented as:
1 device_remove()->
2   bus->remove()->
3     driver->remove()

Driver core needs no inform from callee(bus driver) about the
result of remove callback. In that case, commit fc7a6209d571
("bus: Make remove callback return void") forces bus_type::remove
be void-returned.

Now we have the situation that both 1 & 2 of calling chain are
void-returned, so it does not make much sense for 3(driver->remove)
to return non-void to its caller.

So the basic idea behind this change is making remove() callback of
any bus-based driver to be void-returned.

This change, for itself, is for device drivers based on acpi-bus.

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Lee Jones <lee@kernel.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Dawei Li <set_pte_at@outlook.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for drivers/platform/surface/*
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
48 files changed:
arch/ia64/hp/common/aml_nfw.c
arch/x86/platform/olpc/olpc-xo15-sci.c
drivers/acpi/ac.c
drivers/acpi/acpi_pad.c
drivers/acpi/acpi_video.c
drivers/acpi/battery.c
drivers/acpi/button.c
drivers/acpi/ec.c
drivers/acpi/hed.c
drivers/acpi/nfit/core.c
drivers/acpi/sbs.c
drivers/acpi/sbshc.c
drivers/acpi/thermal.c
drivers/acpi/tiny-power-button.c
drivers/char/sonypi.c
drivers/char/tpm/tpm_crb.c
drivers/hv/vmbus_drv.c
drivers/hwmon/acpi_power_meter.c
drivers/hwmon/asus_atk0110.c
drivers/input/misc/atlas_btns.c
drivers/net/fjes/fjes_main.c
drivers/platform/chrome/chromeos_privacy_screen.c
drivers/platform/chrome/wilco_ec/event.c
drivers/platform/surface/surfacepro3_button.c
drivers/platform/x86/asus-laptop.c
drivers/platform/x86/asus-wireless.c
drivers/platform/x86/classmate-laptop.c
drivers/platform/x86/dell/dell-rbtn.c
drivers/platform/x86/eeepc-laptop.c
drivers/platform/x86/fujitsu-laptop.c
drivers/platform/x86/fujitsu-tablet.c
drivers/platform/x86/intel/rst.c
drivers/platform/x86/lg-laptop.c
drivers/platform/x86/panasonic-laptop.c
drivers/platform/x86/sony-laptop.c
drivers/platform/x86/system76_acpi.c
drivers/platform/x86/topstar-laptop.c
drivers/platform/x86/toshiba_acpi.c
drivers/platform/x86/toshiba_bluetooth.c
drivers/platform/x86/toshiba_haps.c
drivers/platform/x86/wireless-hotkey.c
drivers/platform/x86/xo15-ebook.c
drivers/ptp/ptp_vmw.c
drivers/thermal/intel/intel_menlow.c
drivers/video/backlight/apple_bl.c
drivers/watchdog/ni903x_wdt.c
drivers/xen/xen-acpi-pad.c
include/acpi/acpi_bus.h