mptcp: fix bogus receive window shrinkage with multiple subflows
authorPaolo Abeni <pabeni@redhat.com>
Sat, 16 Sep 2023 10:52:45 +0000 (12:52 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 18 Sep 2023 11:47:55 +0000 (12:47 +0100)
commit6bec041147a2a64a490d1f813e8a004443061b38
tree38cc2760598232c98535644e7ae27989d41dec54
parent8a47558a8c7329e91a58d89c55fc9b8c5beae76b
mptcp: fix bogus receive window shrinkage with multiple subflows

In case multiple subflows race to update the mptcp-level receive
window, the subflow losing the race should use the window value
provided by the "winning" subflow to update it's own tcp-level
rcv_wnd.

To such goal, the current code bogusly uses the mptcp-level rcv_wnd
value as observed before the update attempt. On unlucky circumstances
that may lead to TCP-level window shrinkage, and stall the other end.

Address the issue feeding to the rcv wnd update the correct value.

Fixes: f3589be0c420 ("mptcp: never shrink offered window")
Cc: stable@vger.kernel.org
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/427
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/options.c