blk-mq: fix tags UAF when shrinking q->nr_hw_queues
authorChengming Zhou <zhouchengming@bytedance.com>
Fri, 8 Sep 2023 00:57:02 +0000 (08:57 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 11 Sep 2023 22:17:34 +0000 (16:17 -0600)
commit6be6d112419713334ddd9c01f219ca16adaa4c76
tree18d2b39d8bd624ce27fa3779e95860aed42db0b0
parent0bb80ecc33a8fb5a682236443c1e740d5c917d1d
blk-mq: fix tags UAF when shrinking q->nr_hw_queues

When nr_hw_queues shrink, we free the excess tags before realloc'ing
hw_ctxs for each queue. During that resize, we may need to access those
tags, like blk_mq_tag_idle(hctx) will access queue shared tags.

This can cause a slab use-after-free, as reported by KASAN. Fix it by
moving the releasing of excess tags to the end.

Fixes: e1dd7bc93029 ("blk-mq: fix tags leak when shrink nr_hw_queues")
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Closes: https://lore.kernel.org/all/CAHj4cs_CK63uoDpGBGZ6DN4OCTpzkR3UaVgK=LX8Owr8ej2ieQ@mail.gmail.com/
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20230908005702.2183908-1-chengming.zhou@linux.dev
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c