media: v4l2-subdev: fix regression in check_pad()
authorHans Verkuil <hverkuil@xs4all.nl>
Sat, 29 Jun 2019 13:00:10 +0000 (09:00 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 11 Jul 2019 12:59:54 +0000 (08:59 -0400)
commit6bda7073f335db261345d403123d9a8c0bc1e36b
tree41422ed6eb789dd514e8b6cacf721ee68b632808
parentf81cbfc4f82a75ca0a2dc181a9c93b88f0e6509d
media: v4l2-subdev: fix regression in check_pad()

sd->entity.graph_obj.mdev can be NULL when this function is called, and
that breaks existing drivers (rcar-vin, but probably others as well).

Check if sd->entity.num_pads is non-zero instead since that doesn't depend
on mdev.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Fixes: a8fa55078a77 ("media: v4l2-subdev: Verify arguments in v4l2_subdev_call()")
Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/v4l2-core/v4l2-subdev.c