Actually test compatible depth/stencil attachment formats
authorJason Ekstrand <jason.ekstrand@collabora.com>
Sat, 12 Feb 2022 05:36:02 +0000 (23:36 -0600)
committerMatthew Netsch <quic_mnetsch@quicinc.com>
Fri, 1 Apr 2022 17:16:15 +0000 (17:16 +0000)
commit6ba63887073d184511d53cbb540eaf546109eed2
treed386e24c31111cf105b0b2c8ef457f2f2881dd84
parentdf9e2e3f2f45336a84a42b8fdbb8a771473e20b9
Actually test compatible depth/stencil attachment formats

These tests claimed to test "compatible" depth resolve formats, i.e.,
resolving to a depth-only format from a depth/stencil format.  However,
it only set the depth-only format on the renderpass and not on the
single-sampled image.  This meant it was in violation of the following
VU because the image view and attachment format didn't match:

    VUID-VkRenderPassBeginInfo-framebuffer-03216

    If framebuffer was created with a VkFramebufferCreateInfo::flags
    value that included VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, each
    element of the pAttachments member of a
    VkRenderPassAttachmentBeginInfo structure included in the pNext
    chain must be a VkImageView of an image created with a value of
    VkImageViewCreateInfo::format equal to the corresponding value of
    VkAttachmentDescription::format in renderPass

Unfortunately, once I fixed the format, it turned into a bit of a rabbit
hole because aspects were also messed up various places and then layouts
as well.

Components: Vulkan
Affects: dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*

Change-Id: I34f5dd2cbccae2a695cbe05a22908ba544b0a6a6
external/vulkancts/modules/vulkan/renderpass/vktRenderPassDepthStencilResolveTests.cpp