gdb: Remove a non-const reference parameter
authorAndrew Burgess <andrew.burgess@embecosm.com>
Tue, 2 Jul 2019 11:06:06 +0000 (12:06 +0100)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Wed, 17 Jul 2019 15:24:32 +0000 (16:24 +0100)
commit6b78c3f83c8bcbfa714aab7627ece9673b2d602a
treee8224084dbf069be1e592ea23aeefc509ddf1316
parentd72a9b85651c872378f6dd732cb578f6f055a9b3
gdb: Remove a non-const reference parameter

Non-const reference parameter should be avoided according to the GDB
coding standard:

  https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead

This commit updates the gdbarch method gdbarch_stap_adjust_register,
and the one implementation i386_stap_adjust_register to avoid using a
non-const reference parameter.

I've also removed the kfail from the testsuite for bug 24541, as this
issue is now resolved.

gdb/ChangeLog:

PR breakpoints/24541
* gdbarch.c: Regenerate.
* gdbarch.h: Regenerate.
* gdbarch.sh: Adjust return type and parameter types for
'stap_adjust_register'.
(i386_stap_adjust_register): Adjust signature and return new
register name.
* stap-probe.c (stap_parse_register_operand): Adjust use of
'gdbarch_stap_adjust_register'.

gdb/testsuite/ChangeLog:

PR breakpoints/24541
* gdb.mi/mi-catch-cpp-exceptions.exp: Remove kfail due to 24541.
gdb/ChangeLog
gdb/gdbarch.c
gdb/gdbarch.h
gdb/gdbarch.sh
gdb/i386-tdep.c
gdb/stap-probe.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.mi/mi-catch-cpp-exceptions.exp