kvm: remove IA64 ioctls
authorRadim Krčmář <rkrcmar@redhat.com>
Thu, 20 Nov 2014 13:43:18 +0000 (14:43 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 21 Nov 2014 17:07:33 +0000 (18:07 +0100)
commit6b397158d07f885154b871a15f879d25b3de7579
treea308a01669367283fd06449bcc1587cb400c7efd
parent3bf58e9ae8802bbb6af722a2e7dc4c4d21110c5a
kvm: remove IA64 ioctls

KVM ia64 is no longer present so new applications shouldn't use them.
The main problem is that they most likely didn't work even before,
because of a conflict in the #defines:

  #define KVM_SET_GUEST_DEBUG       _IOW(KVMIO,  0x9b, struct kvm_guest_debug)
  #define KVM_IA64_VCPU_SET_STACK   _IOW(KVMIO,  0x9b, void *)

The argument to KVM_SET_GUEST_DEBUG is:

  struct kvm_guest_debug {
   __u32 control;
   __u32 pad;
   struct kvm_guest_debug_arch arch;
  };

  struct kvm_guest_debug_arch {
  };

meaning that sizeof(struct kvm_guest_debug) == sizeof(void *) == 8
and KVM_SET_GUEST_DEBUG == KVM_IA64_VCPU_SET_STACK.

KVM_SET_GUEST_DEBUG is handled in virt/kvm/kvm_main.c before even calling
kvm_arch_vcpu_ioctl (which would have handled KVM_IA64_VCPU_SET_STACK),
so KVM_IA64_VCPU_SET_STACK would just return -EINVAL.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
include/uapi/linux/kvm.h