tpm: Fix a possible dereference of ERR_PTR in tpm_init()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Tue, 21 Mar 2023 06:14:15 +0000 (23:14 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Mar 2023 08:00:08 +0000 (09:00 +0100)
commit6b301ded45a6d9538f5f579a2e9f4b6c45fa988b
tree0efa15543234ae9acdc71128a6b01741a1079d87
parentfea087fc291b102521427c26da3d0a30c329606f
tpm: Fix a possible dereference of ERR_PTR in tpm_init()

Smatch reports:
drivers/char/tpm/tpm-interface.c:470 tpm_init() error:
'tpm_class' dereferencing possible ERR_PTR()

If class_create() returns error pointer, we are dereferencing a possible
error pointer. Fix this by moving the dereference post error handling.

Fixes: a010eb881243 ("tpm: fix up the tpm_class shutdown_pre pointer when created")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230321061416.626561-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/tpm/tpm-interface.c