Converge common msbuild properties and targets (#338)
authorViktor Hofer <viktor.hofer@microsoft.com>
Sun, 1 Dec 2019 10:01:39 +0000 (11:01 +0100)
committerGitHub <noreply@github.com>
Sun, 1 Dec 2019 10:01:39 +0000 (11:01 +0100)
commit6afe96cc2e950379d13a87efa1fa5a651cbce9bd
tree24a139cdc7eb0a1c13a9bbf49c5c0000f96de615
parent15b5c33507dbb556a44becf773fea1ab1064561c
Converge common msbuild properties and targets (#338)

* Converge common msbuild properties and targets

Moving common msbuild properties and targets into the repo root.

* Consolidate analyzers logic into the repo root

Consolidating msbuild analyzers logic centrally in the repo root and
adding a property switch `EnableAnalyzers` to enable analyzers. We
still need to import the Analyzers.props file unconditionally as
libraries currently doesn't use the PackageReference logic in ref and
src projects and instead uses a depproj to create a props file
dynamically.

* More cleanup to fix CoreLib build
19 files changed:
Directory.Build.props
Directory.Build.targets
eng/Analyzers.props [moved from eng/analyzers.props with 68% similarity]
eng/Build.props
eng/CodeAnalysis.ruleset [moved from src/libraries/CodeAnalysis.ruleset with 100% similarity]
eng/Subsets.props
eng/Tools.props
eng/Versions.props
eng/illink.targets
eng/restore/illink.targets [deleted file]
src/coreclr/src/Directory.Build.targets
src/coreclr/src/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets
src/coreclr/src/System.Private.CoreLib/ILLink.targets [deleted file]
src/coreclr/src/System.Private.CoreLib/System.Private.CoreLib.csproj
src/installer/Directory.Build.props
src/installer/Directory.Build.targets
src/libraries/Directory.Build.props
src/libraries/Directory.Build.targets
src/libraries/restore/analyzers/analyzers.depproj