Turn on -Wrange-loop-analysis.
authorMike Klein <mtklein@chromium.org>
Wed, 26 Oct 2016 14:35:22 +0000 (10:35 -0400)
committerSkia Commit-Bot <skia-commit-bot@chromium.org>
Wed, 26 Oct 2016 15:57:09 +0000 (15:57 +0000)
commit6ad9909fb7ccc973f35bbd222b0f424b8c3df0d2
treee5a4eebf8e097156272d1abf8cb4ed0aad9130c4
parentf93f5151612a4b1adfe1dad0490bd1c01ee73598
Turn on -Wrange-loop-analysis.

-Wrange-loop-analysis triggers when we use a new-style for loop in a way that appears to unintentionally call a copy constructor on each non-trivial loop element instead of operating on them by reference.

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4000

Change-Id: If9e1b7fcc1f2789ae03c41c17abb17e60d564a8b
Reviewed-on: https://skia-review.googlesource.com/4000
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
gn/BUILD.gn
src/sksl/SkSLCompiler.cpp
tests/FontMgrTest.cpp