kbuild: lto: Merge module sections if and only if CONFIG_LTO_CLANG is enabled
authorSean Christopherson <seanjc@google.com>
Mon, 22 Mar 2021 23:44:38 +0000 (16:44 -0700)
committerKees Cook <keescook@chromium.org>
Thu, 1 Apr 2021 21:15:59 +0000 (14:15 -0700)
commit6a3193cdd5e5b96ac65f04ee42555c216da332af
treeb61f86cf72c116c8df62e778709fa3c8037db509
parenta5e13c6df0e41702d2b2c77c8ad41677ebb065b3
kbuild: lto: Merge module sections if and only if CONFIG_LTO_CLANG is enabled

Merge module sections only when using Clang LTO. With ld.bfd, merging
sections does not appear to update the symbol tables for the module,
e.g. 'readelf -s' shows the value that a symbol would have had, if
sections were not merged. ld.lld does not show this problem.

The stale symbol table breaks gdb's function disassembler, and presumably
other things, e.g.

  gdb -batch -ex "file arch/x86/kvm/kvm.ko" -ex "disassemble kvm_init"

reads the wrong bytes and dumps garbage.

Fixes: dd2776222abb ("kbuild: lto: merge module sections")
Cc: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Tested-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20210322234438.502582-1-seanjc@google.com
scripts/module.lds.S