irqchip/versatile-fpga: Apply clear-mask earlier
authorSungbo Eo <mans0n@gorani.run>
Sat, 21 Mar 2020 13:38:42 +0000 (22:38 +0900)
committerMarc Zyngier <maz@kernel.org>
Sun, 22 Mar 2020 11:52:16 +0000 (11:52 +0000)
commit6a214a28132f19ace3d835a6d8f6422ec80ad200
tree53fd92715339dab893c27f707a5ff7e6c2e0bec0
parentb2cb11f4f7643255b7703c0fcabc31a8ec478f3a
irqchip/versatile-fpga: Apply clear-mask earlier

Clear its own IRQs before the parent IRQ get enabled, so that the
remaining IRQs do not accidentally interrupt the parent IRQ controller.

This patch also fixes a reboot bug on OX820 SoC, where the remaining
rps-timer IRQ raises a GIC interrupt that is left pending. After that,
the rps-timer IRQ is cleared during driver initialization, and there's
no IRQ left in rps-irq when local_irq_enable() is called, which evokes
an error message "unexpected IRQ trap".

Fixes: bdd272cbb97a ("irqchip: versatile FPGA: support cascaded interrupts from DT")
Signed-off-by: Sungbo Eo <mans0n@gorani.run>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200321133842.2408823-1-mans0n@gorani.run
drivers/irqchip/irq-versatile-fpga.c