player: Don't try to cache the GQuark for GST_PLAYER_ERROR
authorArun Raghavan <arun@osg.samsung.com>
Thu, 8 Dec 2016 05:52:38 +0000 (11:22 +0530)
committerArun Raghavan <arun@arunraghavan.net>
Thu, 8 Dec 2016 05:52:38 +0000 (11:22 +0530)
commit6a0d53b767be43e937d530dc5b42beb2e71251ab
treefc759d3d8f8427c9da88c33290aed2c8612b9223
parentf149f6bc0ebcd7856813934a457deae17159a174
player: Don't try to cache the GQuark for GST_PLAYER_ERROR

This is potentially racy (in the unlikely scenario that we get two
first-time calls to gst_player_error_quark() at the same time). This
should not impact anything in terms of performance since it's only on
the error path.

The call itself could just be inlined by making GST_PLAYER_ERROR be
defined to the g_quark_from_static_string() call, but this feels ugly
from an API perspective.
gst-libs/gst/player/gstplayer.c