ASoC: dmaengine: Drop unused iov_iter for process callback
authorTakashi Iwai <tiwai@suse.de>
Thu, 31 Aug 2023 13:04:56 +0000 (15:04 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 1 Sep 2023 13:38:29 +0000 (15:38 +0200)
commit69d0fd348d31977368defc3c0737c0ecb824732b
tree51235cc07fc9f737cea6448ab57b36982e5ce883
parentda42bcb30e001d676a1c4cf7f26d15d775279f6c
ASoC: dmaengine: Drop unused iov_iter for process callback

Passing the iov_iter to the process callback is rather buggy, as the
iterator has been already processed for playback.  Similarly, it makes
the copy for capture buggy after the process callback reading the
iterator out.  Moreover, all existing process callbacks don't refer to
the passed iterator at all.  So, it's better to drop the argument from
the process callback.

Fixes: 9bebd65443c1 ("ASoC: dmaengine: Use iov_iter for process callback, too")
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/CAHk-=wje+VkXjjfVTmK-uJdG_M5=ar14QxAwK+XDiq07k_pzBg@mail.gmail.com
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230831130457.8180-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
include/sound/dmaengine_pcm.h
sound/soc/atmel/mchp-pdmc.c
sound/soc/soc-generic-dmaengine-pcm.c
sound/soc/stm/stm32_sai_sub.c