Bluetooth: ISO: handle bound CIS cleanup via hci_conn
authorPauli Virtanen <pav@iki.fi>
Wed, 26 Jul 2023 21:25:26 +0000 (00:25 +0300)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 11 Aug 2023 18:52:32 +0000 (11:52 -0700)
commit69997d50ec574be816b4ee8f9cee52ebbd53f8bd
tree5f698d3a2fde6f2eb491bb77d8f3986ee3bfad06
parent90005880a68cc8908885f5c9c9e2e60deaf78700
Bluetooth: ISO: handle bound CIS cleanup via hci_conn

Calling hci_conn_del in __iso_sock_close is invalid. It needs
hdev->lock, but it cannot be acquired there due to lock ordering.

Fix this by doing cleanup via hci_conn_drop.

Return hci_conn with refcount 1 from hci_bind_cis and hci_connect_cis,
so that the iso_conn always holds one reference.  This also fixes
refcounting when error handling.

Since hci_conn_abort shall handle termination of connections in any
state properly, we can handle BT_CONNECT socket state in the same way as
BT_CONNECTED.

Signed-off-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/hci_conn.c
net/bluetooth/iso.c