btrfs: drop root refs properly when orphan cleanup fails
authorJosef Bacik <josef@toxicpanda.com>
Tue, 7 Feb 2023 16:57:23 +0000 (11:57 -0500)
committerDavid Sterba <dsterba@suse.com>
Mon, 17 Apr 2023 16:01:13 +0000 (18:01 +0200)
commit6989627db074a3db0ca297657bcb8709d8c888c0
treeedb2b50c4b3e24ff3eed16adf01dcb7f45868471
parenta13bb2c03848e4f96f10486ba0b76f8d398bc71c
btrfs: drop root refs properly when orphan cleanup fails

When we mount the file system we do something like this:

while (1) {
lookup fs roots;

for (i = 0; i < num_roots; i++) {
ret = btrfs_orphan_cleanup(roots[i]);
if (ret)
break;
btrfs_put_root(roots[i]);
}
}

for (; i < num_roots; i++)
btrfs_put_root(roots[i]);

As you can see if we break in that inner loop we just go back to the
outer loop and lose the fact that we have to drop references on the
remaining roots we looked up.  Fix this by making an out label and
jumping to that on error so we don't leak a reference to the roots we
looked up.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/disk-io.c